From 51c73163e421dd49cad15773bc253cdce8a8d376 Mon Sep 17 00:00:00 2001 From: Alexander Hess Date: Wed, 18 Sep 2024 20:05:49 +0200 Subject: [PATCH] Refactor `test_top_level_imports()` test cases ... ... into a unified location --- tests/elements/test_top_level_imports.py | 18 ------------------ tests/test_top_level_imports.py | 24 ++++++++++++++++++------ 2 files changed, 18 insertions(+), 24 deletions(-) delete mode 100644 tests/elements/test_top_level_imports.py diff --git a/tests/elements/test_top_level_imports.py b/tests/elements/test_top_level_imports.py deleted file mode 100644 index dd19bcd..0000000 --- a/tests/elements/test_top_level_imports.py +++ /dev/null @@ -1,18 +0,0 @@ -"""Test top-level imports for `lalib.elements`.""" - -from lalib import elements as top_level - - -def test_top_level_imports(): - """Verify `from lalib.elements import *` works.""" - environment = {} - - exec("...", environment, environment) # noqa: S102 - defined_vars_before = set(environment) - - exec("from lalib.elements import *", environment, environment) # noqa: S102 - defined_vars_after = set(environment) - - new_vars = defined_vars_after - defined_vars_before - - assert new_vars == set(top_level.__all__) diff --git a/tests/test_top_level_imports.py b/tests/test_top_level_imports.py index e73cd0e..909e46d 100644 --- a/tests/test_top_level_imports.py +++ b/tests/test_top_level_imports.py @@ -1,18 +1,30 @@ """Test top-level imports for `lalib`.""" -import lalib as top_level +import importlib +from typing import Any + +import pytest -def test_top_level_imports(): - """Verify `from lalib import *` works.""" - environment = {} +@pytest.mark.parametrize( + "path_to_package", + [ + "lalib", + "lalib.elements", + ], +) +def test_top_level_imports(path_to_package: str): + """Verify `from {path_to_package} import *` works.""" + package = importlib.import_module(path_to_package) + + environment: dict[str, Any] = {} exec("...", environment, environment) # noqa: S102 defined_vars_before = set(environment) - exec("from lalib import *", environment, environment) # noqa: S102 + exec(f"from {path_to_package} import *", environment, environment) # noqa: S102 defined_vars_after = set(environment) new_vars = defined_vars_after - defined_vars_before - assert new_vars == set(top_level.__all__) + assert new_vars == set(package.__all__)