From 992d2bb7d41bf5c1af307d2146d65dbe6ecee4c7 Mon Sep 17 00:00:00 2001 From: Alexander Hess Date: Tue, 5 Jan 2021 19:08:52 +0100 Subject: [PATCH] Adjust flake8 ... ... to not complain about implementation details when testing. --- setup.cfg | 2 ++ tests/db/fake_data/factories.py | 2 +- tests/db/test_addresses.py | 4 ++-- tests/db/test_orders.py | 4 ++-- 4 files changed, 7 insertions(+), 5 deletions(-) diff --git a/setup.cfg b/setup.cfg index 6b3f076..f6b291f 100644 --- a/setup.cfg +++ b/setup.cfg @@ -161,6 +161,8 @@ per-file-ignores = WPS430, # Numbers are normal in test cases as expected results. WPS432, + # When testing, it is normal to use implementation details. + WPS437, tests/db/fake_data/__init__.py: # Top-level of a sub-packages is intended to import a lot. F401,WPS201, diff --git a/tests/db/fake_data/factories.py b/tests/db/fake_data/factories.py index 0758667..d9d23d4 100644 --- a/tests/db/fake_data/factories.py +++ b/tests/db/fake_data/factories.py @@ -317,7 +317,7 @@ class AdHocOrderFactory(alchemy.SQLAlchemyModelFactory): obj.delivery_at = None obj.delivery_at_corrected = None obj.delivery_not_confirmed = None - obj._courier_waited_at_delivery = None # noqa:WPS437 + obj._courier_waited_at_delivery = None class ScheduledOrderFactory(AdHocOrderFactory): diff --git a/tests/db/test_addresses.py b/tests/db/test_addresses.py index 8f44352..2d45343 100644 --- a/tests/db/test_addresses.py +++ b/tests/db/test_addresses.py @@ -110,7 +110,7 @@ class TestProperties: def test_is_primary(self, address): """Test `Address.is_primary` property.""" - assert address.id == address._primary_id # noqa:WPS437 + assert address.id == address._primary_id result = address.is_primary @@ -118,7 +118,7 @@ class TestProperties: def test_is_not_primary(self, address): """Test `Address.is_primary` property.""" - address._primary_id = 999 # noqa:WPS437 + address._primary_id = 999 result = address.is_primary diff --git a/tests/db/test_orders.py b/tests/db/test_orders.py index 9fdde79..37eb96a 100644 --- a/tests/db/test_orders.py +++ b/tests/db/test_orders.py @@ -336,7 +336,7 @@ class TestProperties: def test_courier_waited_at_delviery(self, order): """Test `Order.courier_waited_at_delivery` property.""" - order._courier_waited_at_delivery = True # noqa:WPS437 + order._courier_waited_at_delivery = True result = order.courier_waited_at_delivery.total_seconds() @@ -344,7 +344,7 @@ class TestProperties: def test_courier_did_not_wait_at_delivery(self, order): """Test `Order.courier_waited_at_delivery` property.""" - order._courier_waited_at_delivery = False # noqa:WPS437 + order._courier_waited_at_delivery = False result = order.courier_waited_at_delivery.total_seconds()